Discussion:
[rt.cpan.org #104560] [PATCH] list added files in manifest
(too old to reply)
Roderich Schupp via RT
2015-05-27 08:56:54 UTC
Permalink
Wed May 27 04:56:53 2015: Request 104560 was acted upon.
Transaction: Correspondence added by RSCHUPP
Queue: PAR-Packer
Subject: [PATCH] list added files in manifest
Broken in: (no value)
Severity: (no value)
Owner: Nobody
Requestors: ***@cpan.org
Status: new
Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=104560 >
Attached is a patch to list files in the manifest when they are added
using --add-files in a pp call.
The code change is extracted from the patch for RT101800.
The test file is adapted from that patch, but only checks the
extracted manifest.
I applied your patch for RT#104509, thanks Shawn.
The test didn't work for me, though - I replaced it with a simpler one.

Cheers, Roderich
Shawn Laffan
2015-05-28 02:46:26 UTC
Permalink
Thanks Roderich,

The test was a quick adaptation of the one I wrote for the canary file,
which itself is a hacked version of t/20-pp.t.

The canary test could no doubt be more efficient, so any suggestions
welcome.

Shawn.
Post by Roderich Schupp via RT
Wed May 27 04:56:53 2015: Request 104560 was acted upon.
Transaction: Correspondence added by RSCHUPP
Queue: PAR-Packer
Subject: [PATCH] list added files in manifest
Broken in: (no value)
Severity: (no value)
Owner: Nobody
Status: new
Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=104560 >
Attached is a patch to list files in the manifest when they are added
using --add-files in a pp call.
The code change is extracted from the patch for RT101800.
The test file is adapted from that patch, but only checks the
extracted manifest.
I applied your patch for RT#104509, thanks Shawn.
The test didn't work for me, though - I replaced it with a simpler one.
Cheers, Roderich
Loading...